Harden tool policy runtime and malformed decision handling - #251
Open
gut-puncture wants to merge 3 commits into
Open
Harden tool policy runtime and malformed decision handling#251gut-puncture wants to merge 3 commits into
gut-puncture wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers the v2 core policy-runtime hardening for
InteractiveDocumentWithTools.Changes:
observemode fails open (tool executes, logstool_policy_error_observed)enforcemode fails closed (tool blocked, logstool_policy_error_enforced)_evaluate_policy_decision_coerce_policy_decision_apply_policy_decision_policy_error_outcomePolicyDecisionfields (including invalidtagsshape)Why
The previous implementation could incorrectly block tool execution in
observemode for malformed policy output. This PR makes failure semantics explicit and deterministic.Test Coverage
actiontagspayloadValidation
Executed locally:
. .venv/bin/activate && python -m pytest -q concordia/document/interactive_document_tools_test.py. .venv/bin/activate && python -m pytest -q concordia/document/tool_policy_test.py. .venv/bin/activate && python -m pytest -q concordia/document. .venv/bin/activate && python -m pylint --errors-onlyon touched files